karldw commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r698569604
##########
File path: r/tools/nixlibs.R
##########
@@ -82,7 +91,7 @@ download_binary <- function(os = identify_os()) {
# * `TRUE` (not case-sensitive), to try to discover your current OS, or
# * some other string, presumably a related "distro-version" that has binaries
# built that work for your OS
-identify_os <- function(os = Sys.getenv("LIBARROW_BINARY",
Sys.getenv("LIBARROW_DOWNLOAD"))) {
+identify_os <- function(os = Sys.getenv("LIBARROW_BINARY",
Sys.getenv("TEST_OFFLINE_BUILD"))) {
Review comment:
Good catch. I think it should actually just look at `LIBARROW_BINARY`:
```r
identify_os <- function(os = Sys.getenv("LIBARROW_BINARY")) {
...
```
It's maybe worth noting that:
* `identify_os` won't be called at all when `TEST_OFFLINE_BUILD` is `true`
(but could be called if it was set to anything else)
* At an earlier step, `configure` sets `LIBARROW_BINARY=true` if it was
unset and `NOT_CRAN` is `true`
https://github.com/apache/arrow/blob/5a13cbf81ee66172b63341d20acf51efc03d0c97/r/tools/nixlibs.R#L581-L583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
