westonpace commented on a change in pull request #11008:
URL: https://github.com/apache/arrow/pull/11008#discussion_r698734107
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -1998,6 +1998,41 @@ cdef class PartitioningFactory(_Weakrefable):
cdef inline shared_ptr[CPartitioningFactory] unwrap(self):
return self.wrapped
+ @property
+ def type_name(self):
+ return frombytes(self.factory.type_name())
+
+ def create_with_schema(self, schema):
Review comment:
I didn't quite understand what you were doing earlier. Now that I
understand I withdraw my comment although I'm happy to proceed with the C++
changes (Antoine's suggestion makes them much less extensive) if it would help.
Maybe it would be simpler to just allow `write_dataset` to accept a "list of
column names + partitioning format" or a partitioning object? You could
describe the `Partitioning` object as something that is used to represent the
inferred partitioning created by dataset discovery mechanisms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
