zhztheplayer commented on pull request #10883: URL: https://github.com/apache/arrow/pull/10883#issuecomment-908974481
> Would it be good to add tests for DeserializeUnsafeFromJava and SerializeUnsafeFromNative to jni_util_test.cc? > Since we use a few jni methods(GetArrayLength, GetByteArrayElements, NewByteArray, SetByteArrayRegion, ...), we could create a mock jni in the test case. > > Test cases make us clear to do things in the methods. I can give it a try to add mock based tests in C++ side. Actually the round-trip test already covered this? https://github.com/apache/arrow/pull/10883/files#diff-e1e74b2b4a2812b4e273413ec2beb7f89bb62f2a4172f832805d68a87a773107R100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
