pitrou commented on a change in pull request #11031:
URL: https://github.com/apache/arrow/pull/11031#discussion_r699253137
##########
File path: python/pyarrow/parquet.py
##########
@@ -511,11 +513,12 @@ def _sanitize_table(table, new_schema, flavor):
coerce_timestamps : str, default None
Cast timestamps a particular resolution. The defaults depends on `version`.
For ``version='1.0'`` (the default), nanoseconds will be cast to
- microseconds ('us'), and seconds to milliseconds ('ms') by default. For
- ``version='2.0'``, the original resolution is preserved and no casting
- is done by default. The casting might result in loss of data, in which
- case ``allow_truncated_timestamps=True`` can be used to suppress the
- raised exception.
+ microseconds ('us'), and seconds to milliseconds ('ms') by default.
+ For ``version='2.4'``, nanoseconds will be cast to microseconds.
Review comment:
Ah, you're right. Parquet doesn't have seconds.
##########
File path: python/pyarrow/parquet.py
##########
@@ -511,11 +513,12 @@ def _sanitize_table(table, new_schema, flavor):
coerce_timestamps : str, default None
Cast timestamps a particular resolution. The defaults depends on `version`.
For ``version='1.0'`` (the default), nanoseconds will be cast to
- microseconds ('us'), and seconds to milliseconds ('ms') by default. For
- ``version='2.0'``, the original resolution is preserved and no casting
- is done by default. The casting might result in loss of data, in which
- case ``allow_truncated_timestamps=True`` can be used to suppress the
- raised exception.
+ microseconds ('us'), and seconds to milliseconds ('ms') by default.
+ For ``version='2.4'``, nanoseconds will be cast to microseconds.
+ For ``version='2.6'``, the original resolution is always preserved.
Review comment:
Indeed, seconds are still cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
