nealrichardson commented on a change in pull request #11001:
URL: https://github.com/apache/arrow/pull/11001#discussion_r699297589



##########
File path: r/vignettes/install.Rmd
##########
@@ -285,17 +309,28 @@ setting `ARROW_WITH_ZSTD=OFF` to build without `zstd`; or 
(3) uninstalling
 the conflicting `zstd`.
 See discussion [here](https://issues.apache.org/jira/browse/ARROW-8556).
 
+* Offline installation fails when dependencies haven't been downloaded to
+`ARROW_THIRDPARTY_DEPENDENCY_DIR`. The package currently depends on the
+third-party project RapidJSON. See `?download_optional_dependencies`.
+See discussion [here](https://issues.apache.org/jira/browse/ARROW-13768) on

Review comment:
       We should just solve this rather than document the exception, IMO

##########
File path: r/vignettes/install.Rmd
##########
@@ -342,6 +373,15 @@ By default, these are all unset. All boolean variables are 
case-insensitive.
   The directory will be created if it does not exist.
 * `CMAKE`: When building the C++ library from source, you can specify a
   `/path/to/cmake` to use a different version than whatever is found on the 
`$PATH`
+* `ARROW_THIRDPARTY_DEPENDENCY_DIR`: Directory with downloaded third-party
+  dependency files. Run `download_optional_dependencies(my-dir)` to download.
+* `TEST_OFFLINE_BUILD`: When set to `true`, the build script will not download

Review comment:
       A better place for this would be in the developing.Rmd vignette (we have 
another TEST_R_WITHOUT_LIBARROW env var that could also be documented there 
too, like this one it's not something a package user would ever want to do)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to