rok commented on a change in pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#discussion_r699344811
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -337,6 +339,41 @@ struct ISOWeek {
Localizer localizer_;
};
Review comment:
Oh yeah, that's a nice idea.
I'm still trying to exactly match `WEEK` from MySQL and once I do I'll look
into this. Sorry for the WIP.
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -337,6 +339,41 @@ struct ISOWeek {
Localizer localizer_;
};
Review comment:
Early review is great though! :)
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal.cc
##########
@@ -337,6 +339,41 @@ struct ISOWeek {
Localizer localizer_;
};
Review comment:
Early feedback is great though! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
