jorisvandenbossche commented on pull request #10988: URL: https://github.com/apache/arrow/pull/10988#issuecomment-909052240
I didn't yet look at the code, but one note: the `strftime` compute kernel has the same problem (at least for timestamp type, since it doesn't yet support date32/64 formatting. Checking the limits encoded in this PR for timestamp, using one out of range crashes with `strftime`). That can certainly be for another JIRA, but wondering a bit if it might be possible to share some of those checks (the printing should also work if compute is not available I suppose, so cannot directly rely on it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
