waynexia commented on a change in pull request #952:
URL: https://github.com/apache/arrow-datafusion/pull/952#discussion_r698532728
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -76,15 +75,25 @@ fn create_function_physical_name(
Ok(format!("{}({}{})", fun, distinct_str, names.join(",")))
}
-fn physical_name(e: &Expr, input_schema: &DFSchema) -> Result<String> {
+fn physical_name(e: &Expr) -> Result<String> {
+ create_physical_name(e, true)
+}
+
+fn create_physical_name(e: &Expr, is_first_expr: bool) -> Result<String> {
Review comment:
I picked the first one and explained how it is used in the doc comment
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -76,15 +75,25 @@ fn create_function_physical_name(
Ok(format!("{}({}{})", fun, distinct_str, names.join(",")))
}
-fn physical_name(e: &Expr, input_schema: &DFSchema) -> Result<String> {
+fn physical_name(e: &Expr) -> Result<String> {
Review comment:
It's a good point to remove the wrapper. `physical_name()` is an
interior helper function and adding that argument won't be too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
