emkornfield commented on a change in pull request #11031:
URL: https://github.com/apache/arrow/pull/11031#discussion_r698960458
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1805,6 +1805,8 @@ Status WriteTimestamps(const ::arrow::Array& values,
int64_t num_levels,
maybe_parent_nulls);
};
+ const auto version = writer->properties()->version();
Review comment:
nit: spell out type?
##########
File path: python/pyarrow/_parquet.pxd
##########
@@ -133,7 +133,9 @@ cdef extern from "parquet/api/schema.h" namespace "parquet"
nogil:
enum ParquetVersion" parquet::ParquetVersion::type":
ParquetVersion_V1" parquet::ParquetVersion::PARQUET_1_0"
- ParquetVersion_V2" parquet::ParquetVersion::PARQUET_2_0"
+ ParquetVersion_V2_0" parquet::ParquetVersion::PARQUET_2_0"
+ ParquetVersion_V2_4" parquet::ParquetVersion::PARQUET_2_4"
+ ParquetVersion_V2_6" parquet::ParquetVersion::PARQUET_2_6"
Review comment:
should latest be exposed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
