thisisnic commented on a change in pull request #11009:
URL: https://github.com/apache/arrow/pull/11009#discussion_r699588698



##########
File path: r/R/dplyr-functions.R
##########
@@ -825,6 +824,17 @@ agg_funcs$var <- function(x, na.rm = FALSE, ddof = 1) {
     options = list(ddof = ddof)
   )
 }
+
+agg_funcs$n_distinct <- function(x, na.rm = FALSE) {
+  list(
+    fun = "count_distinct",
+    data = x,
+    # ARROW-13764 Passing in na.rm = TRUE doesn't actually work yet as
+    # CountOptions not yet implemented for count_distinct

Review comment:
       Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to