karldw commented on pull request #11001: URL: https://github.com/apache/arrow/pull/11001#issuecomment-909734070
> edit: are you sure you want that? the next line checks if `(!dir.exists())` and returns My goal was to figure out if we're building using the downloaded dependencies by checking if the `download` folder exists in `tools/cpp/thirdparty`. Whether or not we're building the downloaded dependencies, I thought the `tools/cpp/thirdparty` folder should always exist, since it gets copied in by `make build`. This `stopifnot` was a way to check that assumption. (Put differently, testing if `tools/cpp/thirdparty/download` is missing doesn't tell me much if `tools/cpp/thirdparty` is also missing.) Does that seem reasonable? If you have a cleaner way, let me know! The windows builds were failing because I hadn't documented all of my arguments. Hopefully they pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
