edponce commented on a change in pull request #10869:
URL: https://github.com/apache/arrow/pull/10869#discussion_r700396396
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -1766,14 +1812,15 @@ struct IsTitleUnicode {
[&previous_cased, &rule_3](uint32_t codepoint) {
if (IsLowerCaseCharacterUnicode(codepoint)) {
if (!previous_cased) return false; // rule
1 broken
+ // next should be more lower case or uncased
previous_cased = true;
- } else if
(IsCasedCharacterUnicode(codepoint)) {
+ } else if
(IsUpperCaseCharacterUnicode(codepoint)) {
Review comment:
Just for symmetry but I will revert this change as the cased checking is
a bit simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
