nealrichardson commented on pull request #10992:
URL: https://github.com/apache/arrow/pull/10992#issuecomment-910598194


   > The one about the missing warning is trickier / I haven't fully solved it 
yet.
   
   I think what's happening is that the Dataset's schema metadata isn't 
propagated through the ExecPlan, while it was through the Scanner. I changed 
how collect() works in this PR to use ExecPlan so that it could also handle 
aggregations and sorting. 
   
   I'll skip the test for now and make a JIRA. It's not a problem in this test 
(because actually we want the metadata to be dropped) but it would be a problem 
for other contexts where we have `r` metadata.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to