ianmcook commented on a change in pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#discussion_r701081207
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -272,12 +272,27 @@ struct ARROW_EXPORT DayOfWeekOptions : public
FunctionOptions {
constexpr static char const kTypeName[] = "DayOfWeekOptions";
static DayOfWeekOptions Defaults() { return DayOfWeekOptions{}; }
- /// Number days from 1 if true and from 0 if false
+ /// Number from 1 if true and from 0 if false
Review comment:
I think it's best to put back `days` in the `DayOfWeekOptions` docs
since we're now using a different options class for this
```suggestion
/// Number days from 1 if true and from 0 if false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
