liyafan82 commented on a change in pull request #10983:
URL: https://github.com/apache/arrow/pull/10983#discussion_r702553105
##########
File path:
java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTest.java
##########
@@ -230,11 +235,16 @@ public void runLargeNumberOfRows() throws IOException,
SQLException {
int x = 0;
final int targetRows = 600000;
ResultSet rs = new FakeResultSet(targetRows);
- try (ArrowVectorIterator iter = JdbcToArrow.sqlToArrowVectorIterator(rs,
allocator)) {
+ JdbcToArrowConfig config = new JdbcToArrowConfigBuilder(allocator,
JdbcToArrowUtils.getUtcCalendar(), false)
Review comment:
Sounds good. Parameter doc added for this line of code, and also added
for some other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
