liyafan82 commented on a change in pull request #11073:
URL: https://github.com/apache/arrow/pull/11073#discussion_r702733258
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/compare/RangeEqualsVisitor.java
##########
@@ -214,6 +215,18 @@ public Boolean visit(NullVector left, Range range) {
return true;
}
+ @Override
+ public Boolean visit(ExtensionTypeVector<?> left, Range range) {
+ if (!validate(left) || !(right instanceof ExtensionTypeVector<?>)) {
Review comment:
For better performance, `!(right instanceof ExtensionTypeVector<?>)`
could be placed first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
