pitrou commented on a change in pull request #11026:
URL: https://github.com/apache/arrow/pull/11026#discussion_r702997156
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -278,6 +278,23 @@ struct ARROW_EXPORT DayOfWeekOptions : public
FunctionOptions {
uint32_t week_start;
};
+struct ARROW_EXPORT WeekOptions : public FunctionOptions {
+ public:
+ explicit WeekOptions(bool week_starts_monday = true, bool count_from_zero =
false,
+ bool first_week_in_year = false);
+ constexpr static char const kTypeName[] = "WeekOptions";
+ static WeekOptions Defaults() { return WeekOptions{}; }
+
+ /// What day does the week start with (Monday=true, Sunday=false)
+ bool week_starts_monday;
Review comment:
Hmm... did you deliberately choose a different option name and semantics
compared with `DayOfWeekOptions::week_start`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
