lidavidm commented on a change in pull request #11022:
URL: https://github.com/apache/arrow/pull/11022#discussion_r703003007
##########
File path: cpp/src/arrow/compute/kernels/scalar_if_else.cc
##########
@@ -1058,6 +1062,109 @@ void AddFSBinaryIfElseKernel(const
std::shared_ptr<IfElseFunction>& scalar_funct
DCHECK_OK(scalar_function->AddKernel(std::move(kernel)));
}
+// Given a reference dictionary, computes indices to map dictionary values
from a
+// comparison dictionary to the reference.
+class DictionaryRemapper {
Review comment:
This is for if we don't want unification, however, I think we might want
to just unify dictionaries always.
IIRC, what DictionaryUnifier was missing was a way to compute a
transposition map without adding new values to the internal memo table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
