houqp commented on a change in pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#discussion_r703173380
##########
File path: python/Cargo.toml
##########
@@ -30,16 +30,16 @@ edition = "2018"
libc = "0.2"
tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread",
"sync"] }
rand = "0.7"
-pyo3 = { version = "0.14.1", features = ["extension-module"] }
-datafusion = { git = "https://github.com/apache/arrow-datafusion.git";, rev =
"4d61196dee8526998aee7e7bb10ea88422e5f9e1" }
+pyo3 = { version = "0.14.2", features = ["extension-module"] }
+datafusion = { path = "../datafusion", features = ["pyarrow"] }
Review comment:
Using path here is fine, we do the same thing for ballista as well.
Ideally, if the crate needs to be published on crates.io, we will use both
`path` and `version` so it will work with `cargo publish`. But in this case,
version is not required since we don't have plan to publish the python binding
crate to crates.io.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
