felipeblazing commented on a change in pull request #11068:
URL: https://github.com/apache/arrow/pull/11068#discussion_r704502506
##########
File path: cpp/src/arrow/compute/exec/aggregate_node.cc
##########
@@ -225,6 +236,23 @@ class ScalarAggregateNode : public ExecNode {
Future<> finished() override { return finished_; }
+ protected:
+ std::string ToStringExtra() const override {
+ std::stringstream ss;
+ const auto input_schema = inputs_[0]->output_schema();
+ ss << "aggregates=[" << std::endl;
Review comment:
I see this code repeated in group by node. Is there anyway we can make a
function that wraps this functionality so we dont't have to update it twice if
that ever becomes necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
