alamb commented on pull request #873: URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-916251989
> Thanks Andrew for the heads up! I wonder, wouldn't it better if we would assert on record batch equality rather than its string representation? @kszucs -- I agree that doing so would avoid such "small floating point changes require many test changes" type problem. I think the downside is that (in my opinion) the tests are then harder to read and update. Let me prepare a draft PR for updating datafusion to the latest arrow-rs so we can at least decouple the "changes needed for just arrow-rs upgrade" from the other changes in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
