kszucs commented on pull request #873:
URL: https://github.com/apache/arrow-datafusion/pull/873#issuecomment-916256574
> @kszucs -- I agree that doing so would avoid such "small floating point
changes require many test changes" type problem. I think the downside is that
(in my opinion) the tests are then harder to read and update.
I understand, though the test actually tests that the two representations
are equal rather than that the results are equal.
Aren't there other assertion crates providing better checks, perhaps with
optional additional context (as a possible future improvement)?
> Let me prepare a draft PR for updating datafusion to the latest arrow-rs
so we can at least decouple the "changes needed for just arrow-rs upgrade" from
the other changes in this PR
Great, thank You!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
