westonpace commented on a change in pull request #70:
URL: https://github.com/apache/arrow-cookbook/pull/70#discussion_r705753936
##########
File path: python/source/io.rst
##########
@@ -419,7 +422,8 @@ by ``month`` using
.. testcode::
- dataset = ds.dataset("s3://ursa-labs-taxi-data/2011",
+ dataset = ds.dataset("2011",
+ filesystem=s3
Review comment:
Hmm, I suppose I feel this changes the intent a little if the goal was
to demonstrate the ability to create a dataset from a URI.
That being said, I don't know how to make this test work effectively with a
URI. If `anonymous` is not provided then credentials will be fetched from by
the AWS SDK (e.g. from ~/.aws/credentials). If no credentials at all are found
then the request will fail. If you configure any kind of credentials then the
request will pass. Perhaps the C++ library could catch the "no credentials
found" error and try again with anonymous access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
