aocsa commented on pull request #11019: URL: https://github.com/apache/arrow/pull/11019#issuecomment-916583022
Thanks again for the comments @lidavidm. Besides the minor latest changes addressing the feedback I filed follow-up JIRA issues: [C++][Compute] Improve top_k/bottom_k Selecters via CRTP https://issues.apache.org/jira/browse/ARROW-13971 [C++][Compute]Implement SelectKStable https://issues.apache.org/jira/browse/ARROW-13969 [C++][Compute]Implement streaming version for SelectK https://issues.apache.org/jira/browse/ARROW-13970 The first one is an improvement of the selecter and template specialization for specific type. The last two are tasks to implement a streaming version of it and SelectKStable. Apart from that, I think it is ready for final review / merging, let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
