rdettai commented on a change in pull request #965:
URL: https://github.com/apache/arrow-datafusion/pull/965#discussion_r705976547
##########
File path: ballista/rust/core/src/execution_plans/shuffle_reader.rs
##########
@@ -156,6 +158,38 @@ impl ExecutionPlan for ShuffleReaderExec {
fn metrics(&self) -> Option<MetricsSet> {
Some(self.metrics.clone_inner())
}
+
+ fn statistics(&self) -> Statistics {
+ stats_for_partitions(
Review comment:
I would have done it in the constructor if this object was immutable,
but the `partition` field is actually `pub(crate)`. I'll open a separate PR to
make `partition` and `schema` private, thus making it possible to cache the
statistics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
