alamb commented on a change in pull request #910:
URL: https://github.com/apache/arrow-datafusion/pull/910#discussion_r706361582
##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -570,6 +570,7 @@ pub trait Accumulator: Send + Sync + Debug {
pub mod aggregates;
pub mod analyze;
pub mod array_expressions;
+pub mod avro;
Review comment:
I think @nevi-me is suggesting something like
```suggestion
#[cfg(feature = "avro")]
pub mod avro;
```
Which would then let you avoid so much `#[cfg...]` in
https://github.com/apache/arrow-datafusion/pull/910#discussion_r700593118
I am not sure what other changes that entails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
