lidavidm commented on a change in pull request #11130:
URL: https://github.com/apache/arrow/pull/11130#discussion_r706487944
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction*
func) {
base.exec = ExecTemplate<UInt64Type, BooleanType>::Exec;
DCHECK_OK(func->AddKernel(base));
+ // duration type
+ base.signature = KernelSignature::Make({InputType::Array(Type::DURATION)},
uint64());
Review comment:
Sorry, could you clarify? The comment is meant to clarify that this is
adding the kernel that handles duration types (despite since there are a lot of
types in play and it can be a little unclear which case this is)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
