westonpace commented on a change in pull request #11130:
URL: https://github.com/apache/arrow/pull/11130#discussion_r706492186
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -651,6 +651,11 @@ void AddSortingKernels(VectorKernel base, VectorFunction*
func) {
base.exec = ExecTemplate<UInt64Type, BooleanType>::Exec;
DCHECK_OK(func->AddKernel(base));
+ // duration type
+ base.signature = KernelSignature::Make({InputType::Array(Type::DURATION)},
uint64());
Review comment:
Sorry, I meant the comment at the top of the function (alternatively,
you could just remove this comment)
```
// Sort indices kernels implemented for
//
// * Boolean type
// * Number types
// * Base binary types
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
