edponce commented on a change in pull request #11023:
URL: https://github.com/apache/arrow/pull/11023#discussion_r706543733
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -50,13 +50,14 @@ class BaseTestStringKernels : public ::testing::Test {
CheckScalarUnary(func_name, type(), json_input, out_ty, json_expected,
options);
}
- void CheckBinaryScalar(std::string func_name, std::string json_left_input,
- std::string json_right_scalar,
std::shared_ptr<DataType> out_ty,
- std::string json_expected,
- const FunctionOptions* options = nullptr) {
- CheckScalarBinaryScalar(func_name, type(), json_left_input,
json_right_scalar, out_ty,
- json_expected, options);
- }
+ // void CheckBinaryScalar(std::string func_name, std::string json_left_input,
+ // std::string json_right_scalar,
std::shared_ptr<DataType>
+ // out_ty, std::string json_expected, const
FunctionOptions*
+ // options = nullptr) {
+ // CheckScalarBinaryScalar(func_name, type(), json_left_input,
json_right_scalar,
+ // out_ty,
+ // json_expected, options);
+ // }
Review comment:
This was existing code that was not used. I need to provide better
support for binary kernels, so that scalar-array/array-scalar can be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
