novemberkilo commented on pull request #922: URL: https://github.com/apache/arrow-datafusion/pull/922#issuecomment-917565774
Thanks much @alamb I followed your suggestion and set both of those constants to `0.0` and confirmed that the code path that is being hit is the one where `array.is_valid()` is skipped. I reran the benchmarks and still have no appreciable difference to report between my code and what is on `master` This is confusing to me ... perhaps the `is_valid()` call is not as expensive as we thought? Or else the optimisation is still somehow not visible. I'll think about it some more but thought I would post these findings as an interim update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
