houqp commented on pull request #11138: URL: https://github.com/apache/arrow/pull/11138#issuecomment-917571062
@jorgecarleitao even if we don't account for leap seconds, `Interval(1d,MS_IN_DAY)` is still not equal to `Interval(2d,0)` due to daylight saving adjustments. Here is the quote from the comment: ``` // A "calendar" interval which models types that don't necessarily // have a precise duration without the context of a base timestamp (e.g. // days can differ in length during day light savings time transitions). ``` > Since DataFusion follows postgres, I shouldn't we stick to MONTHS_DAYS_NS so that we capture its behavior of storing months, days and (nano)seconds separately, Are you suggesting that we should use `MONTHS_DAYS_NS` everywhere in datafusion and drop day_ms entirely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
