rdettai commented on a change in pull request #965: URL: https://github.com/apache/arrow-datafusion/pull/965#discussion_r706863130
########## File path: datafusion/src/physical_optimizer/aggregate_statistics.rs ########## @@ -0,0 +1,384 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Utilizing exact statistics from sources to avoid scanning data +use std::sync::Arc; + +use arrow::datatypes::Schema; Review comment: Agreed. @alamb @houqp @Dandandan @andygrove... this part is really **the gist of this PR**, because this is where we can really judge whether it is a good idea or not to move CBOs to the physical plan. If you compare this optimization with the one originally performed on the logical plan, you see that it becomes a bit more complex because the physical plan can take many more shapes (vtable instead of enum) and is usually larger than the logical one (one logical aggregation node split represented by multiple physical ones). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
