Dandandan commented on a change in pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#discussion_r706874517
##########
File path: datafusion/src/scalar.rs
##########
@@ -424,6 +424,25 @@ macro_rules! build_array_from_option {
}};
}
+macro_rules! eq_array_general {
+ ($array:expr, $index:expr, $ARRAYTYPE:ident, $VALUE:expr, $has_nulls:expr)
=> {{
+ let array = $array.as_any().downcast_ref::<$ARRAYTYPE>().unwrap();
+ if *$has_nulls {
Review comment:
This branch should be ideally be outside of the loop of
https://github.com/apache/arrow-datafusion/pull/922/files#diff-03876812a8bef4074e517600fdcf8e6b49f1ea24df44905d6d806836fd61b2a8L360
But this might be hard to accomplish given the current design. I posted some
ideas my earlier comment on this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
