Dandandan commented on pull request #972: URL: https://github.com/apache/arrow-datafusion/pull/972#issuecomment-917917074
> @Dandandan if I read the code correctly, it's only using cpu cores in tests. For actual execution, the partition count is read from the context config in physical planner when creating the table scan node: > > ``` > let max_partitions = ctx_state.config.target_partitions; > ``` Thanks, you're right. I skimmed the PR too quickly. Two suggestions I have for the PR: * call it `target_partitions` instead of `max_partitions` * use the `target_partitions` for MemTable as well (instead of using nr of cpu cores) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
