pitrou commented on a change in pull request #11139:
URL: https://github.com/apache/arrow/pull/11139#discussion_r707166100
##########
File path: cpp/src/arrow/io/compressed_test.cc
##########
@@ -273,6 +273,14 @@ TEST(TestSnappyOutputStream, NotImplemented) {
}
#endif
+#if !defined ARROW_WITH_ZLIB \
+ && !defined ARROW_WITH_BROTLI \
+ && !defined ARROW_WITH_LZ4 \
+ && !defined ARROW_WITH_ZSTD
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(CompressedInputStreamTest);
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(CompressedOutputStreamTest);
+#endif
Review comment:
You'll need to define `GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST` in
`arrow/testing/gtest_compat.h` for GTest versions < 1.11.
##########
File path: cpp/src/arrow/io/compressed_test.cc
##########
@@ -273,6 +273,14 @@ TEST(TestSnappyOutputStream, NotImplemented) {
}
#endif
+#if !defined ARROW_WITH_ZLIB \
Review comment:
I don't think you need to make this conditional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
