westonpace commented on a change in pull request #10662:
URL: https://github.com/apache/arrow/pull/10662#discussion_r707644015
##########
File path: cpp/src/arrow/csv/reader.cc
##########
@@ -742,6 +751,25 @@ class ReaderMixin {
return ParseResult{std::move(parser), static_cast<int64_t>(parsed_size)};
}
+ /**
+ * @brief add the `size()` of all buffers in `block` to `parser_offset_`
+ * @return the parser offset which should be used by the caller
+ */
+ int64_t UpdateParserOffset(const CSVBlock& block) {
+ parser_offset_ += block.bytes_skipped;
+ auto result = parser_offset_;
Review comment:
It's been a hard habit for me to break, as I used to do the same thing,
but `result` is not a good variable name. Maybe `updated_offset` or something
like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
