zhztheplayer commented on a change in pull request #10652:
URL: https://github.com/apache/arrow/pull/10652#discussion_r707823639
##########
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java
##########
@@ -26,12 +26,16 @@
/**
* Constructor.
- * @param columns Projected columns. Empty for scanning all columns.
* @param batchSize Maximum row number of each returned {@link
org.apache.arrow.vector.ipc.message.ArrowRecordBatch}
+ * @param columns Projected columns. Null for scanning all columns.
*/
- public ScanOptions(String[] columns, long batchSize) {
- this.columns = columns;
+ public ScanOptions(long batchSize, String[] columns) {
Review comment:
`columns` becomes an optional parameter after this PR. I tended to put
it at tailing position of the parameter list. Regarding the API I would like to
explain to users that they are all all experimental in [another
PR](https://github.com/apache/arrow/pull/10333/files#diff-d83ff4a862278ef11112853a74fc9c0feb2f52ab17c8ffce81c1c84d2a50e5b1R24).
But would you suggest that we should not make breaking changes at this time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
