ianmcook commented on a change in pull request #11156:
URL: https://github.com/apache/arrow/pull/11156#discussion_r708563304
##########
File path: r/R/dplyr-mutate.R
##########
@@ -38,11 +38,13 @@ mutate.arrow_dplyr_query <- function(.data,
.data <- as_adq(.data)
# Restrict the cases we support for now
- if (length(dplyr::group_vars(.data)) > 0) {
+ has_aggregations <- any(unlist(lapply(exprs, all_funs)) %in%
names(agg_funcs))
Review comment:
Currently this will return a false negative if you have a column with
the same name as one of the aggregate functions. I will push an improved
definition of `all_funs` that fixes this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
