Dandandan commented on a change in pull request #1004:
URL: https://github.com/apache/arrow-datafusion/pull/1004#discussion_r708607135
##########
File path: datafusion/tests/sql.rs
##########
@@ -2395,14 +2397,33 @@ async fn explain_analyze_baseline_metrics() {
"FilterExec: c13@1 != C2GT5KVyOPZpgKVl110TyZO0NcJ434",
"metrics=[output_rows=99, elapsed_compute="
);
+ assert_metrics!(
+ &formatted,
+ "GlobalLimitExec: limit=1, ",
+ "metrics=[output_rows=1, elapsed_compute="
+ );
+ assert_metrics!(
+ &formatted,
+ "ProjectionExec: expr=[COUNT(UInt8(1))",
+ "metrics=[output_rows=1, elapsed_compute="
+ );
+ assert_metrics!(
+ &formatted,
+ "CoalesceBatchesExec: target_batch_size=4096",
+ "metrics=[output_rows=5, elapsed_compute"
+ );
fn expected_to_have_metrics(plan: &dyn ExecutionPlan) -> bool {
- use datafusion::physical_plan::{
- hash_aggregate::HashAggregateExec, sort::SortExec,
- };
-
- plan.as_any().downcast_ref::<SortExec>().is_some()
- || plan.as_any().downcast_ref::<HashAggregateExec>().is_some()
+ use datafusion::physical_plan;
+
+ plan.as_any().downcast_ref::<physical_plan::sort::SortExec>().is_some()
+ ||
plan.as_any().downcast_ref::<physical_plan::hash_aggregate::HashAggregateExec>().is_some()
+ // CoalescePartitionsExec doesn't do any work so is not included
+ ||
plan.as_any().downcast_ref::<physical_plan::hash_aggregate::HashAggregateExec>().is_some()
Review comment:
This line seems duplicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
