lidavidm commented on pull request #11159: URL: https://github.com/apache/arrow/pull/11159#issuecomment-920041100
> > why is this a vector kernel instead of a scalar one? > > I think it has to be a scalar kernel if we want to be able to call it in a projection node, which is why we're doing this now--right? Ah, right - plus expressions aren't evaluatable unless they're scalar: https://github.com/apache/arrow/blob/9cf2372b3dc99feadbac0c5e976e69c926883167/cpp/src/arrow/compute/exec/expression.cc#L503-L506 I think most kernels like this pass the second argument via options, not as an argument. I was also debating whether to comment about this, but might as well: there's no need to generate kernels for different index types, especially if we just make the index an option instead of a parameter. (It'll also limit the number of special cases to account for in type coverage testing.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
