rok edited a comment on pull request #11026: URL: https://github.com/apache/arrow/pull/11026#issuecomment-920266611
@jorisvandenbossche thanks for the review! I think there are three open questions here: 1. Do we fully implement MySQL functionality (8 different modes for computing week) or not? Currently this proposal does. [See discussion.](https://github.com/apache/arrow/pull/11026#pullrequestreview-747344728) 2. We can remove one boolean check (per value) from the Week kernel by templating. Should we? 3. Shall we change int DayOfWeekOptions::week_start to bool DayOfWeekOptions::week_starts_monday ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
