edponce edited a comment on pull request #11164: URL: https://github.com/apache/arrow/pull/11164#issuecomment-920372114
If it does not makes sense to invoke `select_k_unstable` without providing a `k` and `sort_keys`, then also make these parameters mandatory in the [`SelectKOptions`](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_vector.h#L126). Although, client code can still provide an invalid value of `k` and an empty vector to `sort_keys`, it expresses the desired intent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
