westonpace commented on pull request #11165: URL: https://github.com/apache/arrow/pull/11165#issuecomment-920396759
@lidavidm `VisitAsyncGenerator`'s visitor should return `Status` so you can still communicate errors (which cause the visiting to stop). I see that it might not be able to interact with `stop_requested_` though (but that could be done in a general way by adding an optional `StopToken` to `VisitAsyncGenerator`). So I suppose I won't push for that change. This looks pretty good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
