pitrou commented on a change in pull request #11164:
URL: https://github.com/apache/arrow/pull/11164#discussion_r709897548
##########
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##########
@@ -2340,6 +2340,9 @@ class SelectKUnstableMetaFunction : public MetaFunction {
return Status::Invalid("SelectK requires a nonnegative `k`, got ",
select_k_options.k);
}
+ if (select_k_options.sort_keys.size() == 0) {
+ return Status::Invalid("SelectK requires `sort_keys` option paremeter,
got {}");
Review comment:
Right. Instead, make the error message explicit: "SelectK requires a
non-empty `sort_keys`".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
