jorisvandenbossche commented on a change in pull request #11008:
URL: https://github.com/apache/arrow/pull/11008#discussion_r709914358



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -1998,6 +1998,10 @@ cdef class PartitioningFactory(_Weakrefable):
     cdef inline shared_ptr[CPartitioningFactory] unwrap(self):
         return self.wrapped
 
+    @property
+    def type_name(self):
+        return frombytes(self.factory.type_name())
+

Review comment:
       That was assuming it would return a useful value. If that's not the 
case, then maybe let's remove it. 
   (do we know what's the reason for "schema"? Because DirectoryPartitioning is 
created with a schema? We could also change the return value in C++)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to