aucahuasi commented on a change in pull request #11159:
URL: https://github.com/apache/arrow/pull/11159#discussion_r710037583



##########
File path: cpp/src/arrow/compute/kernels/test_util.cc
##########
@@ -190,6 +190,13 @@ void CheckVectorUnary(std::string func_name, Datum input, 
Datum expected,
   AssertDatumsEqual(expected, actual, /*verbose=*/true);
 }
 
+void CheckVectorBinary(std::string func_name, Datum v1, Datum v2, Datum 
expected,
+                       const FunctionOptions* options) {

Review comment:
       I think those wrappers are good and make the tests more clear. Please 
note I just added the binary one in this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to