aocsa commented on a change in pull request #11164:
URL: https://github.com/apache/arrow/pull/11164#discussion_r710121208



##########
File path: python/pyarrow/tests/test_compute.py
##########
@@ -1859,35 +1859,42 @@ def validate_select_k(select_k_indices, arr, order, 
stable_sort=False):
             assert actual == expected
 
     arr = pa.array([1, 2, None, 0])
-    for order in ["descending", "ascending"]:
-        for k in [0, 2, 4]:
+    for k in [0, 2, 4]:

Review comment:
       when `k` is greater than input length, `k = input.length`. Same thing 
happens when there are less non-null elements in that array `k = 
first_null_index` after PartitionNull.   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to