anthonylouisbsb commented on a change in pull request #11016:
URL: https://github.com/apache/arrow/pull/11016#discussion_r710193573
##########
File path: cpp/src/gandiva/precompiled/string_ops_test.cc
##########
@@ -92,6 +96,12 @@ TEST(TestStringOps, TestSpace) {
EXPECT_EQ(std::string(out, out_len), " ");
out = space_int64(ctx_ptr, -5, &out_len);
EXPECT_EQ(std::string(out, out_len), "");
+ out = space_int64(ctx_ptr, 65536, &out_len);
+ EXPECT_EQ(std::string(out, out_len), std::string(65536, ' '));
+ out = space_int64(ctx_ptr, 9223372036854775807, &out_len);
+ EXPECT_EQ(std::string(out, out_len), std::string(65536, ' '));
+ out = space_int64(ctx_ptr, -2639077559, &out_len);
Review comment:
I think the error is appearing in the AppVeyor build is because you are
using a value that is lower than the minimum integer.
Try to change to `-2639077559L`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
