edponce commented on a change in pull request #11105:
URL: https://github.com/apache/arrow/pull/11105#discussion_r710923099
##########
File path: r/R/dplyr-functions.R
##########
@@ -672,6 +672,16 @@ nse_funcs$strptime <- function(x, format = "%Y-%m-%d
%H:%M:%S", tz = NULL, unit
Expression$create("strptime", x, options = list(format = format, unit =
unit))
}
+nse_funcs$strftime <- function(x, format = "", tz = "", usetz = FALSE) {
+ if (tz != "") {
+ arrow_not_supported("tz argument")
Review comment:
I am not in favor of casting here and would let the C++ implementation
handle the given inputs. This would ensure a more consistent behavior across
R/Python/C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
