rdettai commented on a change in pull request #1013:
URL: https://github.com/apache/arrow-datafusion/pull/1013#discussion_r710936070
##########
File path: datafusion/src/physical_plan/planner.rs
##########
@@ -296,520 +301,536 @@ impl DefaultPhysicalPlanner {
}
/// Create a physical plan from a logical plan
- fn create_initial_plan(
- &self,
- logical_plan: &LogicalPlan,
- ctx_state: &ExecutionContextState,
- ) -> Result<Arc<dyn ExecutionPlan>> {
- let batch_size = ctx_state.config.batch_size;
-
- match logical_plan {
- LogicalPlan::TableScan {
- source,
- projection,
- filters,
- limit,
- ..
- } => {
- // Remove all qualifiers from the scan as the provider
- // doesn't know (nor should care) how the relation was
- // referred to in the query
- let filters = unnormalize_cols(filters.iter().cloned());
- source.scan(projection, batch_size, &filters, *limit)
- }
- LogicalPlan::Window {
- input, window_expr, ..
- } => {
- if window_expr.is_empty() {
- return Err(DataFusionError::Internal(
- "Impossibly got empty window expression".to_owned(),
- ));
+ fn create_initial_plan<'a>(
+ &'a self,
+ logical_plan: &'a LogicalPlan,
+ ctx_state: &'a ExecutionContextState,
+ ) -> BoxFuture<'a, Result<Arc<dyn ExecutionPlan>>> {
Review comment:
This shows as a big change but only because the function body needs to
be wrapped into a `BoxFuture` with `async { .. }.boxed()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
